refactor connection creation to use Django's APIs #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
connection-creation
branch
2 times, most recently
from
3bfeeb7 to
8ae7e65
Compare
timgraham
force-pushed
the
connection-creation
branch
from
48d123f to
2258c45
Compare
aclark4life
approved these changes
Oct 31, 2024
Jibola
approved these changes
Oct 31, 2024
| @@ -3,6 +3,7 @@ | |||
|
|
|||
|
|
|||
| class DatabaseFeatures(BaseDatabaseFeatures): | |||
| minimum_database_version = (5, 0) | |||
There was a problem hiding this comment.
This is based on 5.0 being what's tested against, correct?
There was a problem hiding this comment.
Correct. Recall that we bumped Mongo 4.4 (copied from Pymongo's CI, I think) to 5.0 in 8bbfc61.
timgraham
force-pushed
the
connection-creation
branch
from
2258c45 to
087000e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.